Fixes misc build related issues and a bug on macOS that uses wrong app icon on stage manager (!250) · Merge requests · leap / bitmask-vpn

Merged jkito requested to merge jkito/bitmask-vpn:macos-icon-misc into main 7 months ago

Sep 08, 2024

deb: update patch for deb package to build with qt6.4 · 473595df
jkito authored 7 months ago and jkito committed 7 months ago

473595df

build: donot rename built app binary · 30a03871

jkito authored 7 months ago and

jkito committed 7 months ago

earlier the qmake build always produced the binary named
as bitmask and later it was renamed to whatever PROVIDER
was set to, in the previous commit we fixed the  setting
of TARGET env so that qmake produces the binary with the
correct name

30a03871

build: pass in PROVIDER env variable to getparam script · 9e535d7c

jkito authored 7 months ago and

jkito committed 7 months ago

running 'getparam binname' should return the name we want to set
for the qmake TARGET based on the PROVIDER from the  vendor.conf
file, due to running it inside a subshell in make it always gets
the value for the default provider, setting PROVIDER env returns
the correct value

it also updates the qmake project file to use the TARGET env var
and the build script to pass TARGET to qmake command as arg

9e535d7c

installer: name helper launchd service based on app name · d869dbf7

jkito authored 7 months ago and

jkito committed 7 months ago

this allows us to have multiple branded desktop clients installed
along side each other

earlier installing one would uninstall the previous helper as both
used the same name and label for the launchd daemon

d869dbf7

qmake: pass RELEASE variable to qmake invocation · f09e7897

jkito authored 7 months ago and

jkito committed 7 months ago

qmake is not inheriting the env variables from the parent
process to work around this, it is directly passed as arg
to the qmake invocation

f09e7897

build: use RELEASE_DIR for path to release build dir · 80c6232e
jkito authored 7 months ago and jkito committed 7 months ago
```
as the RELEASE env variable is used to switch between
release or debug builds
```
80c6232e
qmake: configure for release builds when env RELEASE is yes · 93ebb997
jkito authored 7 months ago and jkito committed 7 months ago

93ebb997

Fixes misc build related issues and a bug on macOS that uses wrong app icon on stage manager

Merge request reports

Activity