Skip to content
Snippets Groups Projects

[README] Update required go version to build to go 1.22

Merged [README] Update required go version to build to go 1.22
fix-876 into main
1 unresolved thread
Merged Pea Nut requested to merge fix-876 into main
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
README.md
76 76 make build
77 77 ```
78 78
79 You need at least go 1.20.
79 To build you need at least go 1.22. On Ubuntu noble (24.04), the `golang` package installs go 1.22 and you are fine. On Ubuntu jammy (22.04), you have to manually install the [golang-1.22](https://packages.ubuntu.com/jammy/golang-1.22) package. The `golang` package installs go 1.18. On Debian 12 (bookworm) you get go 1.19 when installing the `golang` package. You have to install `golang-1.22` from [bookworm-backports](https://packages.debian.org/bookworm-backports/golang-1.22). Debian 11 is out of support, as we moved to qt6 which is not supported on Debian 11 ([issue](https://0xacab.org/leap/bitmask-vpn/-/issues/830)).
  • jkito
    jkito @jkito
    Maintainer

    adding the go installation instructions here means we have to keep it updated when this information changes and increases the maintenance cost, i think just mentioning the minimum go version required like before is fine and let the user determine what best way to get the required version for their os

  • Pea Nut
    Pea Nut @peanut2
    Author Developer

    Now as I already did the work, we can just merge it. A new Debian/Ubuntu release only comes up every 4? years. So I don't see a big deal here.

  • jkito
    jkito @jkito
    Maintainer

    Its the go versions that we have to keep up with, not the distro releases, suppose next month we update to a newer version of go1.22 and its not yet available in backports, then we have to update these instructions, this increases the time one needs to spend when doing a go update which should be simple.

    so eventually these lines will either get outdated or removed

  • Pea Nut changed this line in version 3 of the diff

    changed this line in version 3 of the diff

  • Please register or sign in to reply
  • jkito
  • Pea Nut resolved all threads

    resolved all threads

  • Pea Nut added 15m of time spent at 2024-07-28

    added 15m of time spent at 2024-07-28

  • Pea Nut added 3 commits

    added 3 commits

    • e2baf99a - [README] clarify the use of make package_deb
    • 6b36e5d4 - [README] Update required go version to build to 1.22
    • 4e10c321 - [README] Change order of supported systems

    Compare with previous version

  • jkito
    jkito @jkito
    Maintainer

    can you use lowercase for the commit tags you are using so [readme] instead of [README] i see we have already mixed tag: and [tag] styles :argh:

  • Pea Nut added 2 commits

    added 2 commits

    • 71b36036 - [README] Update required go version to build to 1.22
    • f89075b5 - [README] Change order of supported systems

    Compare with previous version

  • Pea Nut added 6 commits

    added 6 commits

    • f89075b5...003bcce0 - 3 commits from branch main
    • 6ad5bfa4 - [README] clarify the use of make package_deb
    • 6d875691 - [README] Update required go version to build to 1.22
    • 4d28c597 - [README] Change order of supported systems

    Compare with previous version

    Toggle commit list
  • Pea Nut added 15m of time spent at 2024-07-29

    added 15m of time spent at 2024-07-29

  • jkito added 11 commits

    added 11 commits

    • 4d28c597...c1adccae - 8 commits from branch main
    • 030f07d0 - [README] clarify the use of make package_deb
    • d6ecd722 - [README] Update required go version to build to 1.22
    • 1256c39b - [README] Change order of supported systems

    Compare with previous version

    Toggle commit list
  • jkito merged

    merged

    • Please register or sign in to reply