Remove Bitmask.ReloadFirewall and change GetAllGateways to FetchGateways , fixes #824 (!221) · Merge requests · leap / bitmask-vpn

Merged Pea Nut requested to merge fix-824 into main 10 months ago

Jul 10, 2024

Remove function GatewayPool.getAll() · 218c8beb

Pea Nut authored 9 months ago and

jkito committed 9 months ago

It does not have a value any more. Directly calling
GatewayPool.GetGatewaysByTimezone instead. Therefore making it public.

218c8beb

[bonafide] Remove call to p.getGatewaysFromMenshen in gatewayPool.getAll · 2977a431
Pea Nut authored 10 months ago and jkito committed 9 months ago
```
It first checks if p.recommended is len=0, then iterates over it.
```
2977a431

Rename GetAllGateways to FetchAllGateways and change return values of FetchAllGateways · a3049438

Pea Nut authored 10 months ago and

jkito committed 9 months ago

After removing `Bitmask.ReloadFirewall()` there are no calls to `b.api.GetAllGateways()`
where the calling function actually need the gateways as return values. So I renamed the
function to FetchAllGateways. The function now only returns an error (instead of
`([]bonafide.Gateway, error)`). This simplifies the code of v5 a bit, as
we get rid of yet another function/abstraction. In v3 `gatewayPool.getAll()`
now also returns just an error.

a3049438

Remove Bitmask.ReloadFirewall function, fixes #824 · 4b7392e3
Pea Nut authored 10 months ago and jkito committed 9 months ago
```
It's never called.
```
4b7392e3

Remove Bitmask.ReloadFirewall and change GetAllGateways to FetchGateways , fixes #824

Merge request reports

Activity