chore: simplify setting of version for the app

I like the cleanup of how the versioning is done. I understand the appVersion mechanism, but I don't understand how gitArchiveVersion is set. Can you explain it a bit and maybe update the comment?

....so after googling a bit: git archive is called in the Makefile. And the .gitattributes tells git archive to replace values in pkg/config/version/version.go. But I couldn'd find docs about what gets replace (this syntax: $Format:%(describe)$ )

I tried to build it and shows the "-g$commit" version in the UI, so it works for me.

BTW: what do you mean by chore?

git archive we use to create the source tarbll for building the debian package, so in the Makefile VERSION is set to the o/p git tag, but when we have a source tarball made using git archive it is not a git repository (missing .git dir) so the VERSION won't be set, for that we do this .gitattributes magic to replace the string when git archive is called: https://git-scm.com/docs/gitattributes#_export_subst

then in the Version() func we decide which value to use.. i'll add the git attributes link as a comment

chore as in chores, i.e grunt work that needs to be done but doesn't alter functionality/behavior, (https://stackoverflow.com/questions/26944762/when-to-use-chore-as-type-of-commit-message)

approved this merge request

added 30m of time spent at 2024-06-19

added 5 commits

9126a9a3 - chore: simplify setting of version for the app
004fafef - chore: add golangci-lint config and make target to run linter
cc54e80e - chore: add lint stage to gitlabci that runs golangci-lint
25b4c30b - chore: fix artifact upload of build stage in gitlab ci
d76746d5 - chore: remove commented jobs from .gitlab-ci.yaml

Compare with previous version

added 54 commits

d76746d5...d52c5286 - 49 commits from branch leap:main
5e92dac2 - chore: simplify setting of version for the app
cdd981b0 - chore: add golangci-lint config and make target to run linter
bb953145 - chore: add lint stage to gitlabci that runs golangci-lint
e5bed17e - chore: fix artifact upload of build stage in gitlab ci
409ebadc - chore: remove commented jobs from .gitlab-ci.yaml

Compare with previous version

enabled an automatic merge when the pipeline for 409ebadc succeeds

canceled the automatic merge

added 5 commits

50108c0c - chore: simplify setting of version for the app
d1e30476 - chore: add golangci-lint config and make target to run linter
5fbfdc82 - chore: add lint stage to gitlabci that runs golangci-lint
42631e37 - chore: fix artifact upload of build stage in gitlab ci
6f863dcd - chore: remove commented jobs from .gitlab-ci.yaml

Compare with previous version

added 1 commit

c70427a1 - test: skip failing TestLatency in CI

Compare with previous version

enabled an automatic merge when the pipeline for c70427a1 succeeds

merged

chore: simplify setting of version for the app

Merge request reports

Activity