Skip to content
Snippets Groups Projects

[feat] install helpers if needed

Merged [feat] install helpers if needed
meskio/bitmask-vpn:feat/6_install_helpers into master
1 unresolved thread
Merged meskio requested to merge meskio/bitmask-vpn:feat/6_install_helpers into master
1 unresolved thread
Edited by meskio

Merge request reports

Approval is optional

Merged by leap-code-o-maticleap-code-o-matic 7 years ago (Feb 15, 2018 3:26pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
bitmask/main.go
26 27 const (
27 28 // On win should be: tcp://127.0.0.1:5001
28 29 coreEndpoint = "ipc:///tmp/bitmask.core.sock"
30 timeout = time.Second * 40
  • Kali Kaneko
    Kali Kaneko @kali ·
    Owner

    hmm looks a bit high? I think 10 or 20 secs should be enough, isn't it?

  • meskio
    meskio @meskio ·
    Author Contributor

    I was checking and bitmaskctl has a timeout of 60seconds. I thought is too big, but I don't know if there is any call that requires so long to answer, that is why I keep it big. I'm happy to make it smaller.

  • Please register or sign in to reply
  • leap-code-o-matic merged

    merged

    • Please register or sign in to reply