@samba I'm not sure how much it makes sense to have the .desktop in the tgz, as the path of the binary icon and so are dependent on the distro. Looking into the arch documentation it looks like they have tools to generate them in the packages like gendesk:
https://wiki.archlinux.org/index.php/Desktop_entries#Tools
I'm trying to do a make build in archlinux for the pkg risup-vpn.tgz, but when building using the makefile I get some errors:
$ make build go build -tags gtk_3_18 -ldflags "-X main.version=`git describe --tags`" fatal: not a git repository (or any parent up to mount point /) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). ...# github.com/gotk3/gotk3/pango /usr/bin/ld: $WORK/b109/_x002.o: undefined reference to symbol 'g_value_get_enum' /usr/bin/ld: /usr/lib/libgobject-2.0.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status
do you have any recommendation about how to build all using the Makefile or directly with go?
I see, build a go program from a tgz is not a great idea. We should look how other arch packages build go software.
We could 'fix' the problem by adding a ' .' to the end of the go build command, this will build the root of the project correctly, but for all the subfolders it will pick them up from the git repo instead of using the ones in the tgz.
pkgname=riseup-vpnpkgver=0.19.2pkgrel=1pkgdesc="RiseupVPN is a branded build of Bitmask VPN. Bitmask VPN is a minimal rewrite of the Bitmask VPN Client, written in golang, that for now lacks client authentication, and is preconfigured to use a single provider."arch=('x86_64')url="https://0xacab.org/leap/riseup-vpn_package"license=('GPL3')depends=( 'gtk3' 'libappindicator-gtk3' 'python2')makedepends=( 'go' 'git' 'pkgconf')source=( "git+https://0xacab.org/leap/riseup-vpn_package.git")sha1sums=( 'SKIP')build() { cd "${pkgname}_package" go get -u golang.org/x/text/cmd/gotext github.com/cratonica/2goarray go get . go build ./cmd/bitmask-vpn}package() { cd "${pkgname}_package" install -Dm755 helpers/bitmask-root "${pkgdir}/usr/bin/bitmask-root" install -D helpers/se.leap.bitmask.policy "${pkgdir}/usr/share/polkit-1/actions/se.leap.bitmask.policy" install -Dm755 bitmask-vpn "${pkgdir}/usr/bin/$pkgname" install -D debian/riseup-vpn.desktop "${pkgdir}/usr/share/applications/${pkgname}.desktop" install -D debian/icons/scalable/riseupvpn.svg "${pkgdir}/usr/share/icons/hicolor/scalable/apps/riseupvpn.svg"}
That build gets the current commit of the repo, but it can be changed for getting a certain tag :)
Any comment about the PKGBUILD is welcome.
@akuma awesome! any plans of including it in AUR and maintaining it?
I see you're using riseup-vpn_package, that gets pushed all the builds in bitmask-vpn master.
I'm currently working on a branding mechanism that will create templates to generate packages for different OSes. I was thinking I could include a desktop file somewhere not exclusive to debian.
When I tested in arch linux with the default gnome-shell, I had to install the topicons extension in order to get the icon, maybe add it as a dependency?