[BUILD] FileNotFoundError: [Errno 2] No such file or directory: 'build/riseup/snap/data.json'

There is a build issue on Arch Linux. I can't reproduce. Others are also affected. But it looks like there is bug on our side.
Comments on AUR (scroll down): https://aur.archlinux.org/packages/riseup-vpn-git
Build instruction for Arch Linux (just calls PROVIDER=riseup make vendor): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=riseup-vpn-git

Problem:
make vendor calls gen_pkg_snap target. The generate-snap helper wants to write to build/${PROVIDER}/snap/data.json, but build/${PROVIDER}/snap directory does not exist. This is weird, because it is created/copied in the line above:

  gen_pkg_snap:
  ifeq (${PLATFORM}, linux)
      @cp -r ${TEMPLATES}/snap build/${PROVIDER}
      @VERSION=${VERSION} VENDOR_PATH=${VENDOR_PATH} ${SCRIPTS}/generate-snap build/${PROVIDER}/snap/data.json

TEMPLATES=branding/templates/snap and the directory is part of the repo.
I'm in email contact with the person (SamWhited).

$ git clone https://aur.archlinux.org/riseup-vpn-git.git

Cloning into 'riseup-vpn-git'...

$ cd riseup-vpn-git

$ makepkg --nobuild
==> Making package: riseup-vpn-git 0.24.6.rc.1.r7.gd246808-1 (Mon 29 Jul 2024 07:07:14 AM EDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Cloning bitmask-vpn git repo...
Cloning into bare repository '/home/sam/Projects/riseup-vpn-git/bitmask-vpn'...
  -> Found riseup-vpn_launcher.desktop
  -> Found riseup-vpn.png
==> Validating source files with sha256sums...
    bitmask-vpn ... Skipped
    riseup-vpn_launcher.desktop ... Passed
    riseup-vpn.png ... Passed
==> Extracting sources...
  -> Creating working copy of bitmask-vpn git repo...
Cloning into 'bitmask-vpn'...
done.
==> Starting prepare()...
git archive HEAD | tar -x -C ./build/bitmask-vpn_0.24.8-rc.1-src
[+] Generating providers.json...
output: gui/providers/providers.json
[+] Got provider riseup from environment
[+] Configured provider: riseup
[+] Got provider riseup from environment
[+] Configured provider: riseup
Traceback (most recent call last):
  File "/home/sam/Projects/riseup-vpn-git/src/bitmask-vpn/branding/scripts/generate-snap", line 38, in <module>
    writeOutput(data, outputf)
  File "/home/sam/Projects/riseup-vpn-git/src/bitmask-vpn/branding/scripts/generate-snap", line 19, in writeOutput
    with open(outfile, 'w') as outf:
         ^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'build/riseup/snap/data.json'
make: *** [Makefile:395: gen_pkg_snap] Error 1
make: *** Waiting for unfinished jobs....
==> ERROR: A failure occurred in prepare().
    Aborting...

changed title from FileNotFoundError: [Errno 2] No such file or directory: 'build/riseup/snap/data.json' to [BUILD] FileNotFoundError: [Errno 2] No such file or directory: 'build/riseup/snap/data.json'

added 1h of time spent at 2024-07-30

mentioned in merge request !232 (merged)

added 45m of time spent at 2024-08-01

Even after !232 (merged) was merged, I get this error:

pea@peabox:bitmask-vpn PROVIDER=riseup make -j 4
[+] Generating providers.json...
output: gui/providers/providers.json
[+] Got provider riseup from environment
[+] Configured provider: riseup
git archive HEAD | tar -x -C ./build/bitmask-vpn_0.24.8-11-g89e85ee2-src
rm: cannot remove 'build/bitmask-vpn_0.24.8-11-g89e85ee2-src': Directory not empty
make: *** [Makefile:295: clean] Error 1
make: *** Waiting for unfinished jobs....
[+] Got provider riseup from environment
[+] Configured provider: riseup
Traceback (most recent call last):
  File "/home/pea/projects/leap/bitmask-vpn/branding/scripts/generate-snap", line 38, in <module>
    writeOutput(data, outputf)
  File "/home/pea/projects/leap/bitmask-vpn/branding/scripts/generate-snap", line 19, in writeOutput
    with open(outfile, 'w') as outf:
         ^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'build/riseup/snap/data.json'
make: *** [Makefile:399: gen_pkg_snap] Error 1

Need to check...Affetcs the -git build on Arch Linux when called with -j and only sometimes... Also why is snap package prepared when we don't build it...?

changed milestone to %2024.10 LEAP VPN Release

Looks like the No such file or directory (build/riseup/snap) error only happens if there is this previous error: rm: cannot remove 'build/bitmask-vpn_0.24.8-11-g89e85ee2-src': Directory not empty.

It looks like it's this line: @rm -rf $(TGZ_PATH). But -rf should not complain. So no clue why this fails. I also can not reproduce now...

added 15m of time spent at 2024-09-08

fixed in !232 (merged)

closed