Skip to content
Snippets Groups Projects
Open [build] Updates to Makefile
  • View options
  • [build] Updates to Makefile

  • View options
  • Open Issue created by jkito

    Copied from the description in !211 (merged)

    Some things to do/discuss

    1. There is a debian directory with build stuff. But there is also branding/templates/debian. I think the debian dir is not used anymore. I deleted the directory and ran make vendor and make build (on Arch Linux) - that worked. Can we delete the directory?

    2. As you are responsible for Mac/Windows: there are Ansible scripts in scripts/ansible/macos/site.yaml. They also contain qt5. Do we want to update (and test)? Or remove the whole thing?

    3. In gui/build.sh there is also something with qt5 (it's Windows) - Can you fix it?

    QMAKE="`pwd`/../../mxe/usr/x86_64-w64-mingw32.static/qt5/bin/qmake"
    1. There is an install_go target in the Makefile. It is not called/documented. We currently only need it for Debian 12. But the add-apt-repository ppa:longsleep/golang-backports command failed (see above). How to handle that? We can remove it from the Makefile and update the docs (abouth Debian)

    2. In the Makefile, there are two qt5 occurrences with Mac. Can you fix this?

    dependsDarwin:
        @brew install git golang make qt5
        #@brew install --default-names gnu-sed
        @brew link qt5
    1. There is a directory branding/thirdparty/qt5 with a file build-qt5-static.sh. It's not used (if I grep) or documented. Can we delete it?

    2. .github/workflows/nightly.yaml contains some qt5 occurrences (Windows/Mac). Can you fix that?

    3. There are some qt5 occurrences in docs/*. For me we have a lot of outdated documentation we don't use. I think we should create an issue and check all the docs in the repo. Then fix the docs what we find necessary and remove the rest.

    pea@peabox:docs rg qt5
    headless.md
    7:There's a barebones binary that launches the same backend that the qt5 client uses.
    
    build-static.rst
    1:some notes to build the gui with static qt5
    3:QMAKE=/toolchain/qt5-static/bin/qmake TARGET=demolib-vpn ./build.sh
    
    build-osx.rst
    25:* git, make, gpg, golang, qt5. You can get them all with homebrew by doing:
    
    contribution-ideas.md
    32:* Convert snap to use a qt5 base (so that updates are kept small).
    
    cross-compiling-with-mxe.rst
    24:  mxe-x86_64-w64-mingw32.static-qt5
    
    build-snap-canonical.rst
    31:* https://forum.snapcraft.io/t/the-sorry-state-of-snapping-qt5-apps/22809
    32:* https://github.com/mozilla-mobile/mozilla-vpn-client/blob/main/scripts/qt5_compile.sh
    
    • Merge request
    • Branch

    Linked items ... 0

  • Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    Loading Loading Loading Loading Loading Loading Loading Loading Loading Loading