meskio authored 5 years ago and Kali Kaneko committed 5 years ago

bitmask-root firewall isup uses the return code to signal if the
firewall is up or not. We should not report it as an error.

- Resolves: #179

two things happen differently in osx:

- call to systray.Quit() halts the program (so if called directly, none
        of the deferred functions that we use for cleanup get to
        execute)
- systray.Run() blocks (so after loop returns, the main run.Run() function
        did not get to receive the boolean through the finishedCh channel.

proper shutdown is therefore fixed here by moving the call to
systray.Quit() to a goroutine that executes when the initialize()
function calls all the deferred functions.

we need to revisit this in case we want to break the main select loop
for a reson other than successfully terminating the program.

latest release 0.19.6 included a polkit check.
this check is failing in some setups, leading to an unusable experience.
I'm temporarily disabling the check to be able to have an usable release
until we can debug what's causing the issue.

- Related: #152

Before finishing the main thread let's wait for the finish of the
bitmask/pid/... tear down. So the firewall gets down when you ctrl-c.

- Resolves: #142

- Resolves: #141

If bitmask-vpn attempts to connect when there is no internet let's keep retrying
fetching the eip json until internet comes.

- Resolves: #126

When there was no configuration file the 'conf.StartVPN' was set tu
false. Let's set it properly even if there is no config file.

- Resolves: #128

Rename the icon to icon.svg/icon.ico instead of having the name of the
app in it.

- Resolves: #98

this should resolve DNS leaks on windows.

-Resolves: #113