jkito authored 8 months ago and Pea Nut committed 8 months ago

the C import line is recommended to be on a separate line
this allows to use the comments in the lines preceeding it
to setup various cpp compiler flags

this also uses cgo comments to pass additional import dirs
for the cpp compiler, these are needed for gopls to work

jkito authored 8 months ago and Pea Nut committed 8 months ago

instead of converting QString to GoString struct which is
error prone, this changes SetTransport and UseLocation in
backend.go to receive a char* as arg, which is  converted
to Go string using the C.GoString helper

this fixes a bug on macOS where changing preference options
did not have any effect as the conversion of string was not
working and empty values were passed to Go functions

0xacab.org/leap/bitmask-core v0.0.0-20240529192952-8ea2f4de269e => 0xacab.org/leap/bitmask-core v0.0.0-20240705122443-e372171b7c36
golang.org/x/sys v0.17.0 => v0.22.0
github.com/rs/zerolog v1.32.0 => v1.33.0
github.com/stretchr/testify v1.8.4 => v1.9.0

this uses $CI_PROJECT_DIR instead of a hardcoded
path for the project's build dir in the arch pkg
job, the hardcoded path doesn't exist if job run
is from a forked repo

jkito authored 9 months ago and jkito committed 8 months ago

this should help with debugging similar bugs which was
fixed in the previous commit

jkito authored 9 months ago and jkito committed 8 months ago

this fixes a bug where StartFirewall is called with an empty
'gateways' slice leading to blocking outgoing connections to
the openvpn gateway

in startOpenvpn func's global scope there's a 'gateways' var
which is passed to FirewallStart and the gateways are  added
to the firewall's allow list of IPs, this was re-declared in
the code branch for non-private bridge which is out of scope
where FirewallStart is called, leading to an empty 'gateways'
slice being passed to it

jkito authored 9 months ago and jkito committed 8 months ago

both the functions are used to start the obfs4 bridge proxy
one using the bridge connection parameters provided via env
another for starting with the parameters received from  the
api

this commit reuses a single function to start the proxy in both
the scenarios

jkito authored 9 months ago and jkito committed 8 months ago

this updates the helpers starting the obfsvpn bridge
to use the new client interface that was  introduced
in obfsvpn 1.0.0

jkito authored 9 months ago and jkito committed 8 months ago

go1.19 is out of support

Pea Nut authored 9 months ago and jkito committed 8 months ago

It does not have a value any more. Directly calling
GatewayPool.GetGatewaysByTimezone instead. Therefore making it public.

Pea Nut authored 9 months ago and jkito committed 8 months ago

It first checks if p.recommended is len=0, then iterates over it.

Pea Nut authored 9 months ago and jkito committed 8 months ago

After removing `Bitmask.ReloadFirewall()` there are no calls to `b.api.GetAllGateways()`
where the calling function actually need the gateways as return values. So I renamed the
function to FetchAllGateways. The function now only returns an error (instead of
`([]bonafide.Gateway, error)`). This simplifies the code of v5 a bit, as
we get rid of yet another function/abstraction. In v3 `gatewayPool.getAll()`
now also returns just an error.

Pea Nut authored 9 months ago and jkito committed 8 months ago

It's never called.

Pea Nut authored 9 months ago and jkito committed 8 months ago

This fixes a small logic error. Each gateway can be multiple times in
p.recommened (for each transport). If a location was selected manually,
each gateway was added twice to the returned list. The returned list is
the list of gateways we will connect to. For more information, please
check: !213

- provider is bitmask
- version is current main, as testing latest stable in the CI after
  each commit does not have a real benefit
- Added a new directory ArchLinux (there is already a for directory debian)
- There is a new target `package_arch` to create the Arch package - There is a check before if we are on a Arch System
- I did not add the `package_arch`  to the `packages` target (we can not be an Debian and Arch on the same time)
- `make clean` deletes temporary build files
- Updated .gitignore

jkito authored 9 months ago and jkito committed 9 months ago

apart from its use in snowflake/bootstrap.go its also used
to form the path to eip-service.json file on disk and motd
package both expects the provider name instead of provider
url

Pea Nut authored 9 months ago and jkito committed 9 months ago

This reverts commit 6b18a110. The file
gets deployed if installed as package or by using -i/--install-helper.

As discussed in #838. This is a security fix. Normally this file is
deployed by the Debian packge (with 755).

Pea Nut authored 9 months ago and jkito committed 9 months ago

- document environment variables
- add snap install instruction
- standardize a bit
- add PROVIDER= env to build instruction

Pea Nut authored 9 months ago and jkito committed 9 months ago

It is not needed. It's also not available on Ubuntu 22.04.

jkito authored 9 months ago and jkito committed 9 months ago

without running 'make vendor' the resulting client has bitmask
branding but provider is set to riseup

although the default provider is now set to bitmask in the vendor.conf
file

Pea Nut authored 9 months ago and jkito committed 9 months ago

os.MkdirAll returns nil if the directory exists, so we don't check if
it exists.

currently the check expects only RSA private keys but
newer menshen could serve other keys as well

this updates the check to only look for 'PRIVATE KEY'
in the preamble instead of RSA PRIVATE KEY

kwadronaut authored 9 months ago and jkito committed 9 months ago

adds the terms of service url

the test is failing with the following error:
```
--- FAIL: TestLatency (0.00s)
    integration_test.go:65:
        	Error Trace:	/builds/jkito/bitmask-vpn/pkg/vpn/menshen/integration_test.go:65
        	Error:      	Received unexpected error:
        	            	socket: permission denied
        	Test:       	TestLatency
        	Messages:   	Could not calc latency
FAIL
FAIL	0xacab.org/leap/bitmask-vpn/pkg/vpn/menshen	0.029s
```

it is beacause of missing permissons, the pro-bing library attempts
to send an "unprivileged" ping via UDP. On Linux, this must be enabled
with a sysctl command

jobs that were failing were commented to make the CI green
these have now been removed

in the CI we want to make sure that the build works with provider
branding and debian package builds correctly, which is now covered
by the existing jobs: debian, build

the whole build/qt/release directory needs to be uploaded to
be able to download and run it

this sets the artifact expiry time to 1 week to reduce storage
consumption, 1 week should be sufficient as these artifacts are
meant to be tested during development to validate a MR