Skip to content
Snippets Groups Projects
  • Kali Kaneko's avatar
    7085ba13
    [pkg] keep backwards-compatibility for helper location · 7085ba13
    Kali Kaneko authored
    I am honestly amazed at all the things that went wrong with the commit
    a0f8afb9 by sam:
    
    - attempted to fix something that was not broken
    - bumped the build dependency from go 1.14 to go 1.17, even when he had
      been warned that we try to keep backward compatibility to be able to
      build the client in standard or limited enviroments.
    - if you (meaning, any future maintainer) are tempted to bump the go
      version we depend on again, please make sure that the snap, win and
      mac build procedures are updated accordingly.
    - removing one extra dependency is ok, but maintaining compabilitiy for
      builds is even more importan-ter.
    - you cannot just change paths of a top-level folder without grepping
      for the use of those paths. period. I see you fixed linux in
      5ed27792f38e974922a8u, but branding/ scripts still depend on that.
    - if you are going to do this, please open a review process and wait for
      others to chime in.
    - if you are not sure, just fucking ask.
    
    (I better won't mention how many hours were invoiced for this commit,
    because that's fucking unprofessional, lol).
    
    on the positive side, i've learned a few things that can go to a style
    guide in the near future. that's something, I guess :)
    7085ba13
    History
    [pkg] keep backwards-compatibility for helper location
    Kali Kaneko authored
    I am honestly amazed at all the things that went wrong with the commit
    a0f8afb9 by sam:
    
    - attempted to fix something that was not broken
    - bumped the build dependency from go 1.14 to go 1.17, even when he had
      been warned that we try to keep backward compatibility to be able to
      build the client in standard or limited enviroments.
    - if you (meaning, any future maintainer) are tempted to bump the go
      version we depend on again, please make sure that the snap, win and
      mac build procedures are updated accordingly.
    - removing one extra dependency is ok, but maintaining compabilitiy for
      builds is even more importan-ter.
    - you cannot just change paths of a top-level folder without grepping
      for the use of those paths. period. I see you fixed linux in
      5ed27792f38e974922a8u, but branding/ scripts still depend on that.
    - if you are going to do this, please open a review process and wait for
      others to chime in.
    - if you are not sure, just fucking ask.
    
    (I better won't mention how many hours were invoiced for this commit,
    because that's fucking unprofessional, lol).
    
    on the positive side, i've learned a few things that can go to a style
    guide in the near future. that's something, I guess :)