Changed client to allow http

This merge requests adds a --notls flag to all subcommands of bitmaskcfg which send requests to the menshen api. The flag ensures omitting TLS for development reasons is allowed - in case the host url contains http instead of https. This allows us to test a locally running jnk, jnk-compose or a manually setup menshen API on localhost against bitmaskcfg.

closes #2 (closed)

requested review from @cyberta

added 1 commit

• 439820a9 - debug config for vs code

Compare with previous version

added 1 commit

• e07feeba - add no-tls flag to bitmaskcfg tool, revert changes in uTLS client

Compare with previous version

added 3 commits

• 123f8613 - improve documentation that --notls flag only allows omitting TLS in case of a http url
• 8a71ef36 - check if notls flag was set before restricting schemes to https
• df66dfbf - add --notls flag always to the subcommands like locations ls, locations best, config fetch

Compare with previous version

added 1 commit

• 1f900cba - parse no tls flag for locations best command

Compare with previous version

changed the description

changed the description

added 1 commit

• 8e243acc - Added notls flag for bitmask-linux commands

Compare with previous version

changed title from WIP: Changed client to allow http to Changed client to allow http

changed the description

tbh I would think twice before exposing this flag in a public-facing tool.

perhaps conditional compile flags can be added to the mix.

Even if it's called --notls, it's not enforced omitting of TLS, but just the default http client's behavior to use tls for https URLs and no tls for http URLs. I can have a look how much complexity it adds to have a compile flag for this development feature.

mentioned in merge request !4 (merged)

If I recall correctly one issue was: If I disable TLS, it still uses DNS over HTTPs per default:
https://0xacab.org/leap/bitmask-core/-/blob/main/pkg/bootstrap/api.go?ref_type=heads#L36
And this won't work without TLS (in the way it is implemented becauses it uses http2/uTLS). So if we dont use TLS, we also have to disable DNS over HTTP.

added 20m of time spent at 2024-02-13

added 40m of time spent at 2024-02-10

closing in favor of !4 (merged)

closed