Use custom statuses or wordpress internal ones ?
commit c879f1b9 brings two new custom statuses: 'awaiting' and 'moderation'.
First I think there's a confusion : the 'moderation' part of the homepage is only supposed hold links to two pages : one that lists posts with the debate status, and another for the posts that have been refused. So that's not really a post status by itself. I get why you thought so, sorry for the confusion.
Second, when I added this custom status feature, I first thought about adding each and everyone of the status we use, but then didn't:
At some level, given how custom statuses are a bit hackishly handled in wordpress (as discussed in #3), I thought we should try not to add too much of them, and use wordpress internal ones as much as we can. For example, the 'awaiting' status is the 'pending' one in the wordpress world and it may as well work to use this one for that use case.
One thing I am not sure is how it will be possible for people that are not logged in, or do but with a user role without enough capabilities, to see this content displayed on the frontend.
For example, if we query for posts with the pending status in a template, will they be displayed to everyone, or only to people that have the right user role? Will wordpress internal user/role/capability in the end block the display of this kind of content on the frontend? If we can't easily display them, we might need a custom status for the case. I did not test that yet.
I've dumped in the Content status wiki page the list of the different content statuses we use and my thought about that. Curious about what you think