Skip to content
Snippets Groups Projects
  1. Apr 28, 2016
  2. Apr 25, 2016
    • ulif's avatar
      Provide a logger, API-wise. · 70f91b65
      ulif authored
      Add a common place where components can write messages to. Any
      userinterface can decide, what messages should be visible
      (depending on their severity).
      70f91b65
  3. Apr 24, 2016
  4. Apr 20, 2016
    • ulif's avatar
      pep8. · db9165e5
      ulif authored
      Use multiples of 4 as indent, shorten overlong lines and fix
      other minor things to keep pep8-conformity.
      db9165e5
  5. Apr 19, 2016
    • dwcoder's avatar
      Put calculations in right place · a08516d7
      dwcoder authored
      Move the calculations out of the `pre_check()` function.
      Also do smarter checks:
        - If len(sequence) == 1, we don't need any rolls. In this case, just
          return sequence[0]
        - If len(sequence) is a factor of dice_sides, we only need one roll
          along with the modulo operator.
        - For everything else, just require one extra roll, bringing it to a
          total of 2 rolls. This should remove a little bit of the edge bias
          introduced by the modulo
      Run the `pre_check()` function after the calculations have been done.
      
      For the unit tests:
        - remove the function `test_choice_len_too_short()`;
          we no longer have to raise an exception when the sequence length is
          too short.
        - Write new tests for the cases where `dice_sides = 6` and `len(sequence)`:
           - 1
           - 2,3
           - 4,5
      a08516d7
  6. Apr 17, 2016
    • dwcoder's avatar
      Add modulo functionality · 36089112
      dwcoder authored
      Add an if to the pre_check that catches cases where there are less items
      to choose from than sides on the die. If this is the case, we can still
      pick items, but we have to use a modulo.
      Pick the `num_rolls` so that the result generated after rolling is larger
       than `100*len(sequence)`.
      The `pre_check()` function now has to return the modified `num_rolls` as
      well as a boolean to indicate whether modulo needs to be applied on the
      result.
      36089112
    • ulif's avatar
      Update copyright year. · 60ec799f
      ulif authored
      60ec799f
  7. Apr 16, 2016
  8. Apr 15, 2016
  9. Apr 14, 2016
  10. Apr 13, 2016
  11. Mar 22, 2016
  12. Mar 20, 2016
  13. Nov 16, 2015
    • ulif's avatar
      Rename default wordlist from "en_8k" to "en". · b51cadeb
      ulif authored
      Normally, it would be more concise to use the more declarative name.
      "en_8k" tells, how many terms we find in this wordlist. But as the
      wordlist names are used in the CLI and users will normally simply
      look for a wordlist in their language, it can help to keep the name
      of the "default" list for each language short.
      
      We pick the 8K lists for "default" (and not the "original" 6^5
      lists), because we assume that normally people will use diceware
      without dice. Also most other sources of randomness will most
      probably work on a 2^x basis rather than in 6^x (and therefore
      have better use for 8k lists over other ones).
      b51cadeb
  14. Nov 14, 2015
  15. Nov 13, 2015
  16. Nov 12, 2015
  17. Nov 11, 2015
  18. Nov 10, 2015
  19. Nov 09, 2015
  20. Nov 05, 2015
  21. Nov 02, 2015
  22. Aug 03, 2015
    • ulif's avatar
      Fix get_wordlist_path(). · 4a77019c
      ulif authored
      Only return path if it exists and is valid.
      4a77019c
    • ulif's avatar
      Use -w option value. · 547fb2a1
      ulif authored
      Activates the -w option. Turns out we still have to fix
      `get_wordlist_path` at it assumes that wordlists all end in
      ``.txt`` (which is not true).
      547fb2a1
Loading