We were trying to install the wrong path for the bitmask helper service.

- Resolves: #199

kwadronaut authored 5 years ago and meskio committed 5 years ago

Just a tiny space too much in vendor.conf

Signed-off-by: Ruben Pollan <meskio@sindominio.net>

kwadronaut kwadronaut@leap.se authored 5 years ago and meskio committed 5 years ago

Closese #195

Signed-off-by: Ruben Pollan <meskio@sindominio.net>

meskio authored 5 years ago and Kali Kaneko committed 5 years ago

bitmask-root firewall isup uses the return code to signal if the
firewall is up or not. We should not report it as an error.

- Resolves: #179

two things happen differently in osx:

- call to systray.Quit() halts the program (so if called directly, none
        of the deferred functions that we use for cleanup get to
        execute)
- systray.Run() blocks (so after loop returns, the main run.Run() function
        did not get to receive the boolean through the finishedCh channel.

proper shutdown is therefore fixed here by moving the call to
systray.Quit() to a goroutine that executes when the initialize()
function calls all the deferred functions.

we need to revisit this in case we want to break the main select loop
for a reson other than successfully terminating the program.

otherwise we fail miserably. maybe we could do some extra diagnostics when openvpn fails to start.