- 18 Nov, 2020 9 commits
-
-
Mari authored
Redesign nav, add privacy and about pages for splash site See merge request team-friendo/signalboost!481
-
Mari authored
-
Mari authored
-
* obtain fresh docker image by pulling from registry rather than rebuilding locally * cd to `splash` root rather than `signalboost` root. the latter is a vestige of using old docker build process, and messes up calls to docker-compose
-
Mari authored
-
Mari authored
-
aguestuser authored
[#382] Resolve "give admins more warning before deleting channel" Closes #382 See merge request team-friendo/signalboost!480
-
aguestuser authored
-
aguestuser authored
side-effects: * log errors in destroy request issuing and processing * cleanup `_hoursToLive` helper
-
- 17 Nov, 2020 2 commits
-
-
aguestuser authored
-
aguestuser authored
add notification logic to `registrar.phoneNumber.destroy#processDestructionRequest`: * use `repository.destructionRequest#getNotifiableDestructionTargets()` to retrieve all destruction requests that have not been notified in over 8 hours * calculate the remaining time to live of each channel (rounded to nearest day) * construct a pending deletion message in each admin's language around this number and send it to each admin side-effects: * extend `notifier#notifyAdmins` to support notification keys for notifications that are functions with arguments (and not just static strings) * add `util#millisAs`: convenience func to convert milliseconds to different units (weeks, days, hours, minutes)
-
- 13 Nov, 2020 1 commit
-
-
aguestuser authored
-
- 12 Nov, 2020 17 commits
-
-
aguestuser authored
-
aguestuser authored
* retrieve all pending destruction requests that have not been notified in at least 1 day
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
[385] consolidate all "bad message" execute logic into one function Closes #385 See merge request team-friendo/signalboost!479
-
aguestuser authored
-
aguestuser authored
[384] eliminmate vestigal `UNAUTHORIZED` paths in execute layer Closes #384 See merge request team-friendo/signalboost!478
-
aguestuser authored
* in MR !477 we introduced a centralized approach to handling and returning early from incoherent messages containing comamnds (including a sender issuing a command they are not authorized to issue). this is a better approach that is more cohesive and easy to reason about. yay! * it also makes unnecessary the scattered authorization checks in every method in `execute` that might only be issuable by someone with a certain membership status. the previous MR removed the tests for those code paths but not the code paths. * this MR removes the code paths (and cleans up `execute` a bit while we're at it. :))
-
aguestuser authored
[#377] Resolve "BUG: properly handle out-of-context no-payload commands" Closes #377 See merge request team-friendo/signalboost!477
-
aguestuser authored
also make it take up more lines
-
aguestuser authored
* these cases used to be handled as branches of the tests for their individual commands (if admin-only commadns were issued by non-admins or no-payload-commands used to have payload) * however, we have now grouped coverage for all such cases more cleanly in the `ambiguous messages containing commands` test branch * we had left these pending vestigal tests as breadcrumbs in case we wanted to restore the old testing pattern (which we don't), and now leave this commit as a breadcrumb-of-a-breadcrumb in case we change our midn
-
aguestuser authored
GIVEN hotline messages enabled * WHEN a subscriber sends Hello everyone or Accept the consequences (or any other no-payload command, see below) * THEN the message should be treated like a hotline message and forwarded to admins GIVEN hotline messages disabled * WHEN a subscriber sens Hello everyone (or any sentence starting with a 1-word command) * THEN the message should trigger an error message: * IF command is issuable by subscriber/rando (see below) * THEN respond with current error message. ("did you mean to X?") * IF the command is not issuable by a subscriber * THEN respond with a generic "i don't understand, i didn't send that, use HELP" message GIVEN hotline messages in any state * WHEN an admin or rando sends Hello everyone it triggers the "no payload" error message above (potentially we should add "were you trying to send a broadcast message?" to error for admins?) SIDE EFFECT: prompt admin to use broadcast when handling unecessary payload
-
aguestuser authored
Resolve "exempt SUPPORT_CHANNEL and DIAGNOSTICS_CHANNEL from auto-cull job" Closes #383 See merge request team-friendo/signalboost!476
-
aguestuser authored
-
aguestuser authored
-
Mari authored
-
- 11 Nov, 2020 2 commits
-
-
aguestuser authored
Increase prometheus metric retention to 1 month Closes #375 See merge request team-friendo/signalboost!454
-
-
- 09 Nov, 2020 6 commits
-
-
aguestuser authored
[hf] apply stricter checks for redemption See merge request team-friendo/signalboost!475
-
aguestuser authored
-
aguestuser authored
[hotfix] remove subscriber count from INFO command See merge request team-friendo/signalboost!474
-
aguestuser authored
* we don't need to leak that to any random person who sends INFO! * while we're at it, remove the cute joke about cops
-
aguestuser authored
[hotfix] shorten expiry times for channels, hotline messages, invites See merge request team-friendo/signalboost!473
-
aguestuser authored
shorten expiry times as follows: * channels: 4 weeks -> 1 week * hotline message joins: 4 weeks -> 3 days * invites: 2 weeks -> 1 week
-
- 04 Nov, 2020 3 commits
-
-
aguestuser authored
Resolve "BUG: admins sending messages disables disappearing message timer" Closes #356 See merge request team-friendo/signalboost!471
-
aguestuser authored
* SYMPTOM: admin sending message with disappearing message set to any non-zero value will turn disappearing messages off (always) * CAUSE: * for whatever reason, signald now relays normal text messages with the `expiresInSeconds` fields incorrectly set to 0 * this was triggering `dispatcher.detectUpdatableExpiryTime` to think it was handling a `setExpiry` message (when in fact it was not) * FIX: * modify `detectUpdatableExpiryTime` to exclude any message with a non-empty body or attachments fields for consideration as an expiry time udpate message (which works b/c since all true expiry time update messages have empty bodies)
-
aguestuser authored
* upstream MR: https://gitlab.com/thefinn93/signald/-/merge_requests/29 * upstream commit: https://gitlab.com/thefinn93/signald/-/commit/4d5ea9ff49574bedffec2418d7b5168e0663017b * team-friendo MR: team-friendo/signald-fork!24 * team-friendo commit: team-friendo/signald-fork@6735f6a9 * current as of: 2020-10-25
-