TECH TASK: cleanup deletion notifications
cleanup issue for MR !480 (merged)
- abstact the time unit used in notifications so that we could notify in increments other than 24 hours (eg: 30 minutes, 2 days, etc.)
- pass this unit to notification constructors (and translate to 4 langs)
- leverage this abstraction to provide cleaner integration/unit tests[1]
[1] right now we must use a milliseconds-long notification interval in integration tests, but not unit tests because using millis isntead of hours messes up the math used to generate notifications that assume hours as the basic unit. if we made it possible to paramaterize the unit of time, we could also use a milliseconds-long interval in the unit test and avoid the need for this ugly hackery: https://0xacab.org/team-friendo/signalboost/-/blob/1ca7d75d865582ecf9db03f92194cc9763e87709/app/config/jobs.js#L27-33
Edited by aguestuser