Skip to content

BUG: don't send empty messages on disappearing message changes

Bug Description

  • SYMPTOM: when an admin changes the disappearing message timer on their conversation with a channel, then all subscribers receive an empty message
  • CAUSE: the timer change is interpreted by signald as an empty message with a different expiryTime value
  • FIX: modify dispatcher/run.shoudlRelay to drop messages with an empty messageBody that do not contain attachments

Desired Behavior

GIVEN an admin on a channel

  • WHEN the admin changes the disappearing message timer in the conversation with their channel
  • THEN no message should be broadcast to the group

GIVEN the above

  • WHEN an admin sends an attachment or voice memo
  • THEN it should be broadcast
Edited by aguestuser
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information