- 11 Sep, 2020 14 commits
-
-
aguestuser authored
Resolve "admins can undo recycle" Closes #215 See merge request team-friendo/signalboost!384
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
* was sending destruction notification in default lang (EN) to all recipients * should send notification in reach recipient's lang * to fix, provide new impl of `notifyMembersExcept`
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
* calls an async function repeatedly on an interval * returns a function that, if invoked, cancels the next call of the async function
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
* the `common.destroy` function is odd * accepts a nullable channel (instead of just not being called) * has a funny return signature * the fact that it is a method on a channel rather than a function call that accepts a channel (or phone number) forces some tightly coupled testing patterns (that could be cleaner with pure functions on the db) without saving any db queries by doing so * replace it with `channelRepository.destroy` and also create `phoneNumberRepository.destroy`: leaves cleaner test seams and less convoluted branching logcis * clean up tests for destroy that (1) break b/c of this, (2) were tightly coupled and a bit hard to follow/change anyway
-
aguestuser authored
-
aguestuser authored
* get (classified) mature requests * recycle the unredeemed channels * notify admins of redeemed channels that their channel won't be recycled * notify admins of all results (redemption/recycle/recycle-error)
-
- 09 Sep, 2020 4 commits
-
-
aguestuser authored
-
aguestuser authored
-
aguestuser authored
* find all the requests issued before the start of the grace period, indicating channels which should be considered for recycling (b/c their grace period has passed) * make lists of redeemed and unredeemed channel phone numbers, where "redeemed" channels have been used since the start of the grace period, and thus should not be recycled * return them to the caller for processing (ie: we will defer actual recycling to the `registrar` level)
-
aguestuser authored
-
- 08 Sep, 2020 5 commits
-
-
aguestuser authored
* rename `enqueueRecyclablePhoneNumber` to `requestRecycle` * refactor it a bit to streamline (eliminate db call & extra conditional by leveraging `findOrCreate` semantics in repository layer) * move it to the `registrar.phoneNumber.recycle` module * elimininate the `registrar.phoneNumber.enqueRecycle` module
-
aguestuser authored
* fix failing unit tests * while at it: inline and clean up some stub helpers (decouple find stubs from destroy stubs) * refactor for modularity * extract `registrar.phoneNumber.common.destroyChannel` to channel repository * extract `notifyMembers`/ `notifyAdmins` to `registrar.phoneNumber.common`
-
aguestuser authored
* rename from `recycleablePhoneNumberRepository` to `recycleRequestRepository` * only expose one method: `requestToRecyle`, which finds or creates a recycle request for a given phone number
-
aguestuser authored
[#296] Resolve "suggest adding channel name to signal contacts in welcome message" Closes #296 See merge request team-friendo/signalboost!383
-
aguestuser authored
-
- 07 Sep, 2020 11 commits
- 05 Sep, 2020 6 commits
-
-
aguestuser authored
[hotfix] set healthcheck interval to 15 min See merge request team-friendo/signalboost!382
-
aguestuser authored
-
aguestuser authored
[hotfix] reduce socket pool to 1 See merge request !381
-
aguestuser authored
too many concurrent modification errors!
-
aguestuser authored
[hotfix] set healthcheck interval to 5 min See merge request !380
-
aguestuser authored
(at least for now)
-