From 1f905f44ee6e451226a8081e3fd11bc4e2654b6f Mon Sep 17 00:00:00 2001
From: aguestuser <aguestuser@riseup.net>
Date: Wed, 23 Jun 2021 18:44:25 -0400
Subject: [PATCH] [498] remove stray TODOs
---
.../kotlin/info/signalboost/signalc/model/SocketResponse.kt | 2 --
.../kotlin/info/signalboost/signalc/logic/SocketReceiverTest.kt | 2 --
.../kotlin/info/signalboost/signalc/model/SocketResponseTest.kt | 1 -
3 files changed, 5 deletions(-)
diff --git a/signalc/src/main/kotlin/info/signalboost/signalc/model/SocketResponse.kt b/signalc/src/main/kotlin/info/signalboost/signalc/model/SocketResponse.kt
index 9cbe2866..63350773 100644
--- a/signalc/src/main/kotlin/info/signalboost/signalc/model/SocketResponse.kt
+++ b/signalc/src/main/kotlin/info/signalboost/signalc/model/SocketResponse.kt
@@ -108,7 +108,6 @@ sealed class SocketResponse {
}
}
- // TODO: what does signald do here?
@Serializable
@SerialName("decryption_error")
data class DecryptionError(
@@ -205,7 +204,6 @@ sealed class SocketResponse {
}
}
- // TODO: what does signald do here? "unrecognized"?
@Serializable
@SerialName("request_invalid") // TODO: invalidRequest
data class RequestInvalidError(
diff --git a/signalc/src/test/kotlin/info/signalboost/signalc/logic/SocketReceiverTest.kt b/signalc/src/test/kotlin/info/signalboost/signalc/logic/SocketReceiverTest.kt
index 081009c0..1a4ac35a 100644
--- a/signalc/src/test/kotlin/info/signalboost/signalc/logic/SocketReceiverTest.kt
+++ b/signalc/src/test/kotlin/info/signalboost/signalc/logic/SocketReceiverTest.kt
@@ -314,8 +314,6 @@ class SocketReceiverTest : FreeSpec({
client.send(sendRequestJson)
eventually(timeout) {
coVerify {
- // TODO(aguestuser|2021-02-04): we dont' actually want this.
- // we want halting errors to be treated like SendResult statuses below!
app.socketSender.send(
requestHandlingError(request, error)
)
diff --git a/signalc/src/test/kotlin/info/signalboost/signalc/model/SocketResponseTest.kt b/signalc/src/test/kotlin/info/signalboost/signalc/model/SocketResponseTest.kt
index 553391e6..84226199 100644
--- a/signalc/src/test/kotlin/info/signalboost/signalc/model/SocketResponseTest.kt
+++ b/signalc/src/test/kotlin/info/signalboost/signalc/model/SocketResponseTest.kt
@@ -122,7 +122,6 @@ class SocketResponseTest : FreeSpec({
}
"of Cleartext" - {
- // TODO: modify to match signald
val response = genCleartext()
"encodes to JSON" {
--
GitLab