@paz thanks for your work, and sorry for the late reply. This looks good to me, although I feel that I might lack some context and haven't been working with the codebase lately.
I left just one question and I noticed that I stumble across the frequent usage of if ! {some condition}
, which I personally find a bit hard to read. But it might also be that due to my conditioning to use unless in these cases, which is also the rubocop default.
Closes #435
Is this variable assignment needed here?
@paz thanks! Unfortunately, I also have no idea about exim and can not give any feedback on the content.
Ref !386
Nina (57b15958) at 22 Nov 18:35
Merge branch 'spec-drop-pkill' into 'release-5.0'
... and 1 more commit
Thanks! Looks good to me, the pipeline should succeed after a rebase.
Nina (08d7737f) at 13 Sep 10:09
Nina (52dbbc01) at 13 Sep 09:25
@georg done
This implements fetching keys via HTTP (without dirmngr), and only use gpg for importing them. It also features looking up keys at a VKS keyserver (e.g. keys.openpgp.org) first, before looking them up at a SKS keyserver.
It adds a new dependency: (lib)curl. That is required by the networking library, which was chosen because it allows to specify socks-proxies (with which one can route traffic via TOR).
It's a breaking change because we drop a config option (keyserver
) and also change the way how network requests can be influenced (no dirmngr.conf
anymore but new config options).
Closes #361
Nina (3e8375ff) at 13 Sep 08:06
Merge branch 'keyservers-directly' into 'release-5.0'
... and 15 more commits
Nice, thanks!
Nina (7c888241) at 11 Sep 16:25
Revert "Add dependency on net-http gem"
Nina (2de33897) at 11 Sep 16:24
Set load defaults config to version 7.0
Closes #125