Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
schleuder
schleuder
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • schleuder
  • schleuderschleuder
  • Issues
  • #360

Closed
Open
Opened Jul 07, 2018 by init void@init

x-set-fingerprint sets empty fingerprint-value in subscription if there is an accidental line-break between E-Mail and Fingerprint

Expected Behavior

If the line with the command looks like this:

x-set-fingerprint mail@example.com

The command should return an error-message that no valid fingerprint was found.

Actual Behavior

The command empties the fingerprint field of the subscription and answers.
"Fingerprint for some_mail@mail.com set to ."

Steps to Reproduce the Problem

The line for the x-set-fingerprint-Command gets pretty long with the full length fingerprint. Unfortunately some E-Mail-Clients force a line-break between the e-mail and the FP. So the command in the request-mail looks like this:

x-set-fingerprint mail@example.com
0392CF72B345256BB730049789226FD6A42B2A7A

Specifications

  • Version: 3.2.2-1~bpo9+1
  • deb package
  • Mail client version: Thunderbird

Other information

I like paz idea from IRC:

12:49 <@paz> the functionality is wanted, one should be able to unset a fingerprint. But the described behaviour is not useful. We should maybe provide X-UNSET-FINGERPRINT, and protect X-SET-FINGERPRINT against (accidental) mis-use.

Assignee
Assign to
3.3.0
Milestone
3.3.0
Assign milestone
Time tracking
None
Due date
None
Reference: schleuder/schleuder#360