Commit 50e96975 authored by Michał "rysiek" Woźniak's avatar Michał "rysiek" Woźniak 🔒

minor fixes suggested by @georg in !302

parent 6e1730f4
Pipeline #33384 failed with stages
in 10 minutes and 35 seconds
......@@ -20,6 +20,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
* Handle incoming mails encrypted to an absent key, using symmetric encryption or containing PGP-garbage in a more graceful manner: Don't throw an exception, don't notify (and annoy) the admins, instead inform the sender of the mail how to do better. (#337)
* Add missing List-Id header to notification mails sent to admins. This should help with filtering such messages, which is currently not easy to do in a reliable way.
## [3.4.1] / 2019-09-16
### Fixed
......
......@@ -37,7 +37,7 @@ ActiveRecord::Schema.define(version: 20190906194820) do
t.boolean "keep_msgid", default: true
t.boolean "bounces_drop_all", default: false
t.boolean "bounces_notify_admins", default: true
t.boolean "deliver_selfsent", default: true
t.boolean "deliver_selfsent", default: true
t.boolean "include_list_headers", default: true
t.boolean "include_openpgp_header", default: true
t.integer "max_message_size_kb", default: 10240
......
......@@ -759,8 +759,7 @@ describe Schleuder::List do
it "sends the message to all subscribers including the sender, if deliver_selfsent is true and the mail is correctly signed" do
list = create(:list, send_encrypted_only: false, deliver_selfsent: true)
key_material = File.read("spec/fixtures/default_list_key.txt")
sub, msgs = list.subscribe("admin@example.org", nil, true, true, key_material)
sub, msgs = list.subscribe("admin@example.org", nil, true, true)
key_material = File.read("spec/fixtures/example_key.txt")
sub, msgs = list.subscribe("user1@example.org", nil, false, true, key_material)
mail = Mail.new
......@@ -796,8 +795,7 @@ describe Schleuder::List do
it "sends the message to all subscribers but not the sender, if deliver_selfsent is false and the mail is correctly signed" do
list = create(:list, send_encrypted_only: false, deliver_selfsent: false)
key_material = File.read("spec/fixtures/default_list_key.txt")
sub, msgs = list.subscribe("admin@example.org", nil, true, true, key_material)
sub, msgs = list.subscribe("admin@example.org", nil, true, true)
key_material = File.read("spec/fixtures/example_key.txt")
sub, msgs = list.subscribe("user1@example.org", nil, false, true, key_material)
mail = Mail.new
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment