1. 12 Aug, 2019 3 commits
  2. 09 Aug, 2019 2 commits
  3. 21 Jun, 2019 1 commit
  4. 20 Jun, 2019 1 commit
  5. 18 Jun, 2019 1 commit
  6. 08 Jun, 2019 1 commit
  7. 07 Jun, 2019 2 commits
  8. 31 May, 2019 3 commits
  9. 30 May, 2019 1 commit
  10. 22 May, 2019 1 commit
  11. 18 May, 2019 1 commit
    • azul's avatar
      fix redirect after deleting post without js · 89f92296
      azul authored
      We were redirecting to page_url which failed for
      deleting direct personal posts which do not have a page
      associated.
      
      Includes test that triggered the exception and is now fixed.
      89f92296
  12. 15 May, 2019 5 commits
    • dgt's avatar
      Merge branch '282-fix-500-on-double-join' into 'master' · d27fda55
      dgt authored
      Resolve "500 when adding user twice to group"
      
      Closes #282
      
      See merge request !264
      d27fda55
    • azul's avatar
      Merge branch '19-email-notifications-are-broken' into 'master' · 823dd466
      azul authored
      Resolve "email notifications are broken"
      
      See merge request !262
      823dd466
    • azul's avatar
      fix: return 409 when approving redundant requests · 5e50d4f3
      azul authored
      We were responding with 500 and an error popup
      when a request was approved for an action that had already been performed.
      
      For example when approving the removal of a former member
      that had already left the group on their own
      we responded with a 500.
      
      This changes the response to 409 - conflict:
      `    This response is sent when a request conflicts with the current state of the server.`
      
      I was also considering 404 - especially for requests
      to remove a non-member.
      However a 404 for an update on a request
      would seem more like the request itself could not be found.
      
      This commit introduces the Request::PointlessAction exception.
      It will be raised by requests whos action has already been performed.
      
      It allows us to unify error handling on the controller level
      and detect the different errors in each request class
      and reraise them with a common more semantic error class.
      5e50d4f3
    • azul's avatar
      test: failing tests for #282 · 5247682d
      azul authored
      5247682d
    • azul's avatar
      test: actually trigger requests · c29a0c1f
      azul authored
      also turned instance vars into local vars
      as they were not reused anywhere.
      c29a0c1f
  13. 13 May, 2019 1 commit
  14. 09 May, 2019 2 commits
  15. 08 May, 2019 7 commits
  16. 06 May, 2019 6 commits
  17. 05 May, 2019 2 commits