crabgrass issueshttps://0xacab.org/liberate/crabgrass/-/issues2019-05-05T15:36:21Zhttps://0xacab.org/liberate/crabgrass/-/issues/268Data integrity of group participations2019-05-05T15:36:21ZdgtData integrity of group participationsCleanup group participations when
* a page is deleted
* a group is deleted
* a group is removed from a page
Use mark_for_deletion to remove group participationsCleanup group participations when
* a page is deleted
* a group is deleted
* a group is removed from a page
Use mark_for_deletion to remove group participationshttps://0xacab.org/liberate/crabgrass/-/issues/263Investigate JavaScript Warnings2019-05-05T15:20:33ZdgtInvestigate JavaScript WarningsInvestigate/get rid of JavaScript warnings:
* Empty String passed to getElementById() when adding/removing tagsInvestigate/get rid of JavaScript warnings:
* Empty String passed to getElementById() when adding/removing tagshttps://0xacab.org/liberate/crabgrass/-/issues/250Some pages cannot be saved due to invalid page terms encoding2019-05-08T10:18:15ZazulSome pages cannot be saved due to invalid page terms encodingWhen attempting to save an asset page it would raise a mysql error when trying to update the page terms.
the asset in question had a .txt thumbnail - but that file seemed to contain a binary.
Looks like we have some assets that have br...When attempting to save an asset page it would raise a mysql error when trying to update the page terms.
the asset in question had a .txt thumbnail - but that file seemed to contain a binary.
Looks like we have some assets that have broken .txt thumbnails.
We should either check the text for a valid encoding before attempting to insert it into the page terms or we should at least catch the error and make sure processing can proceed.https://0xacab.org/liberate/crabgrass/-/issues/245Can't find wiki section foo2019-05-08T10:18:28ZPeanutCan't find wiki section fooI added some content to section **foo** already existing wiki. Immediately afterwards I wanted to edit it, but I'm getting the error **Can't find wiki section foo**, and similar error for any other section in the wiki.
I misformatted my...I added some content to section **foo** already existing wiki. Immediately afterwards I wanted to edit it, but I'm getting the error **Can't find wiki section foo**, and similar error for any other section in the wiki.
I misformatted my additions to the wiki a bit, accidentally including some additional paragraphs as a headline, and I speculate that this is what might have triggered this bug.https://0xacab.org/liberate/crabgrass/-/issues/210Error when clearing html of group wikis2019-05-05T15:16:51ZdgtError when clearing html of group wikis```
Completed 500 Internal Server Error in 25884ms (ActiveRecord: 25877.6ms)
ActiveRecord::StatementInvalid (Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction: UPDATE wikis, pages SET wikis.body_html = NU...```
Completed 500 Internal Server Error in 25884ms (ActiveRecord: 25877.6ms)
ActiveRecord::StatementInvalid (Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction: UPDATE wikis, pages SET wikis.body_html = NULL WHERE pages.data_id = wikis.id AND pages.data_type = 'Wiki' AND pages.owner_id = XXXX AND pages.owner_type = 'Group' ):
app/models/wiki.rb:200:in `clear_all_html'
app/models/group.rb:309:in `update_name_copies'
app/controllers/group/settings_controller.rb:8:in `update'
```https://0xacab.org/liberate/crabgrass/-/issues/116page of deleted user becomes unaccessible2019-05-05T13:01:04Zazulpage of deleted user becomes unaccessibleIf the owner of a page deletes their account the page becomes unaccessible by anyone else who previously had access.
Steps to reproduce:
* create a page as green granting access to red
* visit page as both... it's accessible
* delete acc...If the owner of a page deletes their account the page becomes unaccessible by anyone else who previously had access.
Steps to reproduce:
* create a page as green granting access to red
* visit page as both... it's accessible
* delete account as green
* try to visit page as red
Result:
'Page could not be found'
Desired result:
See the same page as before. Maybe change the owner of that page to green.https://0xacab.org/liberate/crabgrass/-/issues/112make use of advanced fixtures2019-05-05T11:00:00Zazulmake use of advanced fixturessee Advanced Fixtures section in http://api.rubyonrails.org/v4.2.10/classes/ActiveRecord/FixtureSet.htmlsee Advanced Fixtures section in http://api.rubyonrails.org/v4.2.10/classes/ActiveRecord/FixtureSet.htmlhttps://0xacab.org/liberate/crabgrass/-/issues/111Translations with `%{thing} are hard in many languages2019-05-05T11:02:53ZazulTranslations with `%{thing} are hard in many languagesIt's impossible to translate correctly all the strings that have %{thing} on it. These "things" in catalan have genre, and it can be male (group, comittee) or female (page, network, request), implying different constructions in the rest ...It's impossible to translate correctly all the strings that have %{thing} on it. These "things" in catalan have genre, and it can be male (group, comittee) or female (page, network, request), implying different constructions in the rest of the string. We need that this strings were separed for each thing!https://0xacab.org/liberate/crabgrass/-/issues/73Ensure we track user visits correctly2019-05-05T11:03:14ZazulEnsure we track user visits correctlyWe have a number of users with last_seen_at nil. Some of them are Ghosts. Some have never used their account after they created it i guess. But some have updated_at fields that are largely different from the created_at ones.
Where do we...We have a number of users with last_seen_at nil. Some of them are Ghosts. Some have never used their account after they created it i guess. But some have updated_at fields that are largely different from the created_at ones.
Where do we update last_seen_at and why does this not work for some users?