1. 10 May, 2019 1 commit
    • dgt's avatar
      Preparation for Rails 5 · 7a912d4c
      dgt authored
      first make everything work locally with rails 5.0
      test do not pass on CI yet because the test task has to be rewritten
      
      - update dependecies
      - run rails app:update task: update config, generate intitializers etc.
      - the method hide_action is not available in rails anymore
      - ActionController::Parameters have to be converted to a hash
      - protect_from_forgery now defaults to prepend:false
      7a912d4c
  2. 02 Jun, 2018 2 commits
    • dgt's avatar
      Wiki policies · 8390d1c8
      dgt authored
      we ensure that all permissions are checked via the after_action
      :verify_authorized in the base controller
      in policies edit is an alias for update. we prefer the use of 'update'
      8390d1c8
    • azul's avatar
      WIP: start using pundit · 9a751b8c
      azul authored
      * bundle pundit
      * migrate AssetPermissions to AssetPolicy
      * migrate PagePermissions to PagePolicy
      9a751b8c
  3. 12 Sep, 2017 1 commit
  4. 02 Jul, 2017 1 commit
    • azul's avatar
      refactor: Controller#seed instead of overwriting initialize · 77eb697f
      azul authored
      Initialize is extended multiple times by modules. These modules
      will take any number of args and hand them on:
      
      def initialize(*)
        ...
        super
      end
      
      The original ActionController::Base#initialize however does not accept
      arguments. If we extend initialize in Page::BaseController there is no
      way of telling if we are dealing with such an extended controller as
      ```
      controller.method(:initialize).arity
      ```
      will always return -1.
      
      We could allow seeding in all controllers that a DispatchController
      might dispatch to. But that implies a lot of knowledge of the dispatcher
      about its targets.
      
      Instead we now allow defining a `seed` method on the controller that
      will be called to hand over the page, group and user if it exists.
      77eb697f
  5. 01 Feb, 2017 1 commit
  6. 01 Sep, 2016 2 commits
  7. 14 Sep, 2015 1 commit
    • azul's avatar
      simplify task_list_page - no more task_lists · 8c36d7f8
      azul authored
      TaskLists used to be an empty table that linked pages and
      their tasks together:
      * page.data -> TaskList
      * task.task_list -> TaskList
      
      This commit removes the TaskLists entirely. Instead tasks
      now belong to the page itself. TaskListPages have no more data
      set.
      
      This cleanup removes an intermediate class we never really used anyway.
      
      In general i plan to move away from relying on the polymorphic page
      belongs_to data. Instead data belongs_to page and only the page types
      it's relevant to have the corresponding has_many associations defined.
      This allows for much more flexibility in attaching data to the page.
      8c36d7f8
  8. 21 Aug, 2015 1 commit
    • azul's avatar
      tasks: fix unassigning last user · 2e7e3a3f
      azul authored
      if all checkboxes are unchecked the browser does not submit the param
      at all instead of submitting an empty array.
      
      So if the param is not present we have to assume it's an empty array.
      This is odd and may break intuition if anyone wants to talk to the
      server directly. But i don't see any better way to fix this right now.
      2e7e3a3f
  9. 11 Dec, 2014 1 commit
  10. 06 Dec, 2014 1 commit
  11. 12 Oct, 2014 1 commit
  12. 29 Sep, 2014 1 commit
  13. 27 Sep, 2014 1 commit
  14. 18 Sep, 2014 1 commit
    • azul's avatar
      include all styles and js and cache header · e5bedf63
      azul authored
      We don't have any as_needed styles or scripts that would be worth excluding.
      
      Caching the head saves ~25 ms on each request. Not that much but still more than the 5 ms the data transfer of the entire css file takes. Further more these will be cached on the client anyway.
      e5bedf63
  15. 23 Feb, 2013 1 commit
  16. 31 Jul, 2012 1 commit
  17. 25 Aug, 2011 1 commit
  18. 24 Oct, 2010 1 commit