GitLab

See https://github.com/ooni/probe/issues/1335

Release 0.23.0

Part of https://github.com/ooni/probe-engine/issues/1181

* First draft of checkin API

* Correcting names

* Tests

* Update probeservices/checkin.go
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* Update model/checkininfo.go
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* Update probeservices/checkin_test.go
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* Update probeservices/checkin.go
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* check for result.WebConnectivity == nil

* adding ReportID

* Adding parameters

* Fix parameters

* comment

* Start implementing the wrapper

* Update session.go

* Adding integration tests

* fix: enforce GC and sleep for more time

* format

* fix(session.go): use the correct probe ASN

* fix: message format and testing

* fix(oonimkall): add one more test case
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* fix(testusing.bash): add --yes to command line

See https://github.com/ooni/probe-engine/runs/1774531547?check_suite_focus=true

* fix: new way of installing casks?!

This allows us to switch branches without committing files we
should not be committing and publishing.

See https://github.com/ooni/probe-engine/issues/1184

The reader is already fully read, so falling through does not have
side effects. But doing a continue is cleaner.

While there, make sure we account for TextMessages size.

* fix(build-cli.sh): use macos as alias for darwin

Occurred to me while working on https://github.com/ooni/probe/issues/1315

* feat(build-cli.sh): also build for linux/386

Part of https://github.com/ooni/probe/issues/1315

* feat(build-cli.sh): build for windows/386

Part of https://github.com/ooni/probe/issues/1315.

chore: bless 0.23.0-alpha.1

* fix: allow mixing different nettests inside run

Since https://github.com/ooni/probe-engine/pull/1182 we can mix
urlgetter and dnscheck when using run. This is not awesome because
it violates implicit constraints in pipeline, explorer.

Specifically, a single reportID should always contain just a
single kind of nettests.

On top of that, submitting measurements using a reportID containing
the `run` experiment name was also very lame.

With this diff, we are making a decisive step forward by basically
changing the reportID we're using whenever we need it.

To this end, we change the way in which we submit. We're not using
the algorithm used by mobile resubmission.

This feels like part of https://github.com/ooni/probe-engine/issues/921.

* Update mockable.go

* fix: the diff can actually be simpler

We should ONLY use model when it's needed. Otherwise, let us just
put the data structures we need where we need them.

* fix: more consistent naming

There's a bunch of geolocate only things that really need to be
just part of geolocate, without further indirections.

* refactor: merge locationlookup and geolocate

While doing that, make sure that all the APIs that we don't need
to expose are private APIs. This change should significantly reduce
the cognitive complexity of understanding geolocate.

* fix(geolocate): it seems running all tests is ~quick

While there, refactor the implementation for increased correctness.

* build automatically for rpi3 and rpi4

* build-cli: add missing options

* feat: proposal to automatically build for raspberry pi

* fix: put all linux builds together
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* extended run for urlgetter

* fix(urlgetter.go): zap unnecessary mutex
Co-authored-by: Simone Basso <bassosimone@gmail.com>

fix(android): pin ndk version and repair build

While there, ensure we build Android and iOS also in release
branches. So we notice issues _before_ releasing.

* chore: update dependencies

* chore: update user agent used for measurements

* chore: update bundled CA pool

* chore: use latest assets

* chore: bless 0.22.0

* added readfrom/writeto saving for UDP(QUIC) transport

* extended QUIC SystemDialer tests

* added necessary changes for readfrom/writeto event saving

* covered readfrom/write to archival with test

* dns dialer for http3 transport

* added HTTP3Dialer to http3transport test

* use config to pass dialers to http factory

* explicitly initialising fields

* more explicit comment

* changed name NewHTTP3Dialer

* added forgotten TODO comment back in

* removed inconsistent error return statements

* added more integration tests

* close UDP connection

* improved error handling, added respective test

* test DialEarly error path

* use errors.Is pattern

* fix: make sure tests pass on macOS

* Update netx/dialer/http3dns.go

* Update netx/dialer/http3dns_test.go

* Update netx/httptransport/http3transport_test.go

* use context for http3 dialer

* use custom tls config for http3 transport

* h3 qa: added tests for custom SNI and CA bundle

* added test for unverified sni

* pr review 4/12: avoid casting, use tls.Config

* pr review 4/12: wrapped long lines

* pr review 4/12: small changes Mock HTTP3 Dialing

* pr review 4/12: removed "Unit" from test names

* added explanation for Wrapper Dialer

* saver dialer, simplified dns dialer

* quic error handling

* added quic error wrapper

* connection state cast

* workaround connectionstate go 1.14

* quic connection state workaround

* deleted old file

* added readwritesaver

* renaming QUICDialers

* renaming quic dialer files

* added first tests for quic saver dialers

* added more quic saver tests

* removed go version sensitive test fields

* safe readmsgUDP function

* added tests for quic error classification/wrapping

* added quic_handshake for saver dialers

* fixed quicsaver test

* removed stupid udp connection closing that caused false positives

* preferred quic error format: prefix "quic_"

* pr review 2021/01/07: smaller changes

* removed unused QUICBaseDialer

* pr review 2021/01/07: suggested changes in QUICSystemDialer

* pr review 2021/01/07: design changes

* pr review 2021/01/07: refactored QUIC errorx

* added quicdialer package, renamed its files

* exposed dialer.ReduceErrors

* moved PeerCerts to netx/trace

* quicdialer: annotate doubts and refactor

Avoid names like quicdialer.QUICFoo. We're already into the quicdialer
package, so we can save typing the QUIC prefix.

Wrap lines that seem to long (a subjective call, of course).

It seems there were two similar mockable dialers, so unify them such
that we only have one. We gain a little in simplicity.

* removed QUIC SaverDialer

* only use one host string for QUIC DialContext()

* quicdialer: continue review

A couple of cosmetic changes. Removed likely redundant tests. Note
that we still need to implement one more test here.

* netx/quic: minor adjustements to comments

* mention a couple more TODOs

* record the last todo to keep in mind

* remove what seems to be a duplicate test
Co-authored-by: Simone Basso <bassosimone@gmail.com>

* fix(session): much better code to lookup location

I have abstracted the algorithm such that it's testable and I have
written tests ensuring the result is consistent.

* address feedback by @kelmenhorst

* use well known constants in tests

* add missing docucomment

Part of https://github.com/ooni/probe-engine/issues/1170

Related to https://github.com/ooni/probe-cli/pull/187/files#r553480623.

fix(dnscheck): defend against residual censorship