! Establish an upstream relationship with ics-openvpn codebase
20:54 <@parmegv> elijh: this AIDL thing has made me to think that we should be able to update ics-openvpn without changing anything from our side 20:55 <@parmegv> I think we're adding layers to it, more than reprogramming it 20:55 ! t2d2 [~t@g226039197.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds] 20:55 <@elijh> parmegv: i see the temptation, but can we still do this with a single download? 20:55 <@parmegv> we could do the same that cyanogenmod does 20:55 <@parmegv> it pull from aosp 20:55 <@parmegv> and integrates into his codebase 20:56 <@parmegv> so we could have one apk 20:56 <@parmegv> which would include ics-openvpn code 20:56 <@elijh> i like that approach 20:56 <@parmegv> the problem with it is that we'd have to bundle the UI 20:56 <@elijh> oh 20:56 <@parmegv> or 20:57 <@parmegv> automatically discarding it after pulling it 20:57 <@elijh> ics-openvpn doesn't have good code separation between what is exposed via AIDL and the UI components? 20:57 <@parmegv> that's a point to research 20:57 <@elijh> unless the code is poorly written, it should be possible to just drop the parts we won't use 20:57 <@parmegv> yes, that's why I think it can be done "automatically" 20:58 <@parmegv> but I think a better solution would be to ask arne to make his openvpn interface standalone 20:58 <@parmegv> and let him plug the UI the same way we'd do it 20:58 <@parmegv> a library approach, I think 20:59 <@parmegv> but yes, the first solution could be to discard UI parts with a script 20:59 <@parmegv> with gradle it shouldn't be difficult 20:59 ! siel [~siel@unaffiliated/motley] has quit [Ping timeout: 240 seconds] 20:59 <@elijh> as long as we are not forced to use something weird, like use the credentials storage 21:01 <@parmegv> where, in the ics-openvpn layer? 21:01 <@parmegv> I think that we should start collaborating with arne more closely 21:01 ! siel [~siel@unaffiliated/motley] has joined #leap 21:02 <@parmegv> and try to enhance his codebase using our needs as a booster 21:04 <@elijh> that sounds like a good idea 21:04 <@elijh> (re: credentials, i don't think it uses it now, i just know that some of the other openvpn apps in the market do) 21:07 <@parmegv> ok, then I'll study ics-openvpn from the point of view of AIDL, and try to locate the entry points for us 21:07 <@parmegv> afterwards, check what UI code can be easily dropped 21:08 <@parmegv> and finally try to implement the whole solution 21:08 <@parmegv> not from the beginning, since MeanderingCode may have done a lot of the necessary work with his EIP work 21:09 <@parmegv> s/work/class 21:09 <@parmegv> I know we've touched some parts in our ics-openvpn folder 21:10 <@parmegv> so I'll try to see if they can be imported by arne (so this would be our first contact with regards with our collaboration) 21:10 <@parmegv> and of course if they aren't necessary anymore because arne already fixed those bugs 21:10 <@parmegv> (which will be the case, I think, for at least 1 issue I have in mind right now)
(from redmine: created on 2014-03-25, closed on 2014-06-20)
- Relations:
- relates #5667 (closed)
- child #5584 (closed)
- child #5585 (closed)
- child #5593 (closed)
- child #5624 (closed)
- child #5681 (closed)
- child #5680 (closed)
- child #5686 (closed)
- child #5690 (closed)
- child #5701 (closed)
- child #5708 (closed)
- child #5709 (closed)