From 4b7392e3974987d33d71f1832f6a86be684c80f2 Mon Sep 17 00:00:00 2001 From: Pea Nut <peanut2@systemli.org> Date: Thu, 4 Jul 2024 22:26:50 +0200 Subject: [PATCH] Remove Bitmask.ReloadFirewall function, fixes #824 It's never called. --- pkg/bitmask/interface.go | 1 - pkg/vpn/openvpn.go | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/pkg/bitmask/interface.go b/pkg/bitmask/interface.go index 8abcd720..b3ba2d9f 100644 --- a/pkg/bitmask/interface.go +++ b/pkg/bitmask/interface.go @@ -28,7 +28,6 @@ type Bitmask interface { CanStartVPN() bool StopVPN() error Reconnect() error - ReloadFirewall() error GetStatus() (string, error) VPNCheck() (helpers bool, priviledge bool, err error) GetLocationQualityMap(protocol string) map[string]float64 diff --git a/pkg/vpn/openvpn.go b/pkg/vpn/openvpn.go index c8c60241..7d64e20b 100644 --- a/pkg/vpn/openvpn.go +++ b/pkg/vpn/openvpn.go @@ -474,28 +474,6 @@ func (b *Bitmask) Reconnect() error { return b.startOpenVPN(ctx) } -// ReloadFirewall restarts the firewall -func (b *Bitmask) ReloadFirewall() error { - err := b.launch.FirewallStop() - if err != nil { - return err - } - - status, err := b.GetStatus() - if err != nil { - return err - } - - if status != Off { - gateways, err := b.api.GetAllGateways("any") - if err != nil { - return err - } - return b.launch.FirewallStart(gateways) - } - return nil -} - // GetStatus returns the VPN status func (b *Bitmask) GetStatus() (string, error) { status := Off -- GitLab