improve error messages when authenticating
The error messages returned by the core on authentication errors are like:
Authentication hook did not return anything
The traceback is:
2016-08-22 14:07:20+0200 [HTTP11ClientProtocol (TLSMemoryBIOProtocol),client] Unhandled Error Traceback (most recent call last): File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 393, in callback self._startRunCallbacks(result) File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks self._runCallbacks() File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 588, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1184, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks result = g.send(result) File "/home/meskio/dev/leap/bonafide/src/leap/bonafide/session.py", line 96, in authenticate self._srp_auth.process_handshake(handshake) File "/home/meskio/dev/leap/bonafide/src/leap/bonafide/_srp.py", line 49, in process_handshake self._check_for_errors(challenge) File "/home/meskio/dev/leap/bonafide/src/leap/bonafide/_srp.py", line 77, in _check_for_errors raise SRPAuthError(unicode(msg).encode('utf-8')) leap.bonafide._srp.SRPAuthError: Not a valid username/password combination 2016-08-22 14:07:20+0200 [HTTP11ClientProtocol (TLSMemoryBIOProtocol),client] Authentication hook did not return anything 2016-08-22 14:07:20+0200 [HTTP11ClientProtocol (TLSMemoryBIOProtocol),client] Unhandled Error Traceback (most recent call last): File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1184, in gotResult _inlineCallbacks(r, g, deferred) File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1174, in _inlineCallbacks deferred.errback() File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 434, in errback self._startRunCallbacks(fail) File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks self._runCallbacks() --- --- File "/home/meskio/dev/leap/env/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 588, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/meskio/dev/leap/bonafide/src/leap/bonafide/service.py", line 64, in notify_bonafide_auth raise RuntimeError(msg) exceptions.RuntimeError: Authentication hook did not return anything
(from redmine: created on 2016-08-22, closed on 2016-08-29, relates #8226 (closed))