From bbed21e07d3c01e39a2eb8a74c7f07854ac86bee Mon Sep 17 00:00:00 2001
From: andrew bezella <andrew@diatribes.org>
Date: Fri, 25 Nov 2022 21:26:00 -0800
Subject: [PATCH] SC2045: Iterating over ls output is fragile. Use globs.
---
handlers/rsync.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/handlers/rsync.in b/handlers/rsync.in
index c639538..eee3545 100644
--- a/handlers/rsync.in
+++ b/handlers/rsync.in
@@ -324,7 +324,7 @@ function rotate_short {
fi
# Cleanup orphaned metadata
- for file in `ls $metadata`; do
+ for file in "$metadata/"*; do
if [ ! -d "`dirname $folder`/$file" ]; then
debug "removing orphaned metadata $file"
rm -rf $metadata/$file
@@ -503,7 +503,7 @@ function rotate_long {
done
# Cleanup orphaned metadata
- for file in `ls $backuproot/metadata`; do
+ for file in "$backuproot/metadata/"*; do
if [ ! -d "$backuproot/$file" ]; then
debug "removing orphaned metadata $file"
rm -rf $backuproot/metadata/$file
--
GitLab