From 180ea24e5a050393051ffc8df1fcff8373f59783 Mon Sep 17 00:00:00 2001
From: jvoisin <julien.voisin@dustri.org>
Date: Mon, 21 Nov 2022 19:42:31 +0100
Subject: [PATCH] Remove pyflakes
Isn't borderline useless compared to mypy and pylint
---
.gitlab-ci.yml | 6 ------
libmat2/archive.py | 3 ---
libmat2/office.py | 3 ---
mat2 | 7 +------
4 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index e497ef8..97354ba 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -38,12 +38,6 @@ linting:pylint:
# Once nautilus-python is in Debian, decomment it form the line below
- pylint --disable=no-else-return,no-else-raise,no-else-continue,unnecessary-comprehension,raise-missing-from,unsubscriptable-object,use-list-literal --extension-pkg-whitelist=Nautilus,GObject,Gtk,Gio,GLib,gi ./nautilus/mat2.py
-linting:pyflakes:
- image: $CONTAINER_REGISTRY:linting
- stage: linting
- script:
- - pyflakes3 ./libmat2 ./mat2 ./tests/ ./nautilus
-
linting:mypy:
image: $CONTAINER_REGISTRY:linting
stage: linting
diff --git a/libmat2/archive.py b/libmat2/archive.py
index 5f058b9..25ff7f9 100644
--- a/libmat2/archive.py
+++ b/libmat2/archive.py
@@ -11,9 +11,6 @@ from typing import Pattern, Union, Any
from . import abstract, UnknownMemberPolicy, parser_factory
-# Make pyflakes happy
-assert Pattern
-
# pylint: disable=not-callable,assignment-from-no-return,too-many-branches
# An ArchiveClass is a class representing an archive,
diff --git a/libmat2/office.py b/libmat2/office.py
index ae6ef39..1c1bca8 100644
--- a/libmat2/office.py
+++ b/libmat2/office.py
@@ -12,9 +12,6 @@ from .archive import ZipParser
# pylint: disable=line-too-long
-# Make pyflakes happy
-assert Pattern
-
def _parse_xml(full_path: str) -> tuple[ET.ElementTree, dict[str, str]]:
""" This function parses XML, with namespace support. """
namespace_map = dict()
diff --git a/mat2 b/mat2
index 342003e..c85d353 100755
--- a/mat2
+++ b/mat2
@@ -2,7 +2,7 @@
import os
import shutil
-from typing import Tuple, List, Union, Set
+from typing import List, Union, Set
import sys
import mimetypes
import argparse
@@ -19,11 +19,6 @@ except ValueError as ex:
__version__ = '0.13.0'
-# Make pyflakes happy
-assert Set
-assert Tuple
-assert Union
-
logging.basicConfig(format='%(levelname)s: %(message)s', level=logging.WARNING)
def __print_without_chars(s: str):
--
GitLab