Skip to content

Clarify usage of Salsa/Gitlab reviews for Tails

Some months ago some people have started using Gitlab, Debian’s instance of it - to be precise, ie. salsa.d.o.

It has been suggested to do reviews there, the FT is already practising this.
Other people could benefit from it too, but I’m afraid that the usage is not entirely clear, at least not to me, see comments on https://salsa.debian.org/tails-team/tails/commit/1163ae808f9b6009b7a446a99dc25d3dd9982477

In the future, we will move everything to Gitlab, so a question for clarification arises even more.

I also see that there are merge requests on this repository: https://salsa.debian.org/tails-team/tails/merge_requests
What’s happening to them? They are open since 5-6 months, so I understand that they are not merged there?

Maybe we should clarify the usage, benefits and expectations of doing reviews over Gitlab’s web interface? In a very informal way, for example, by exchanging best practices or simply writing an email about how this should be used.

Is there any documentation written by/for the FT that clarifies this and that I or other people could read?

Or is this something that we will address by writing contributor documentation once we’ve really moved to Gitlab?

Related issues

Original created by @u on 17172 (Redmine)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information