UEFI test is broken for Tails based on buster

This is about Scenario: Booting Tails from a USB drive in UEFI mode.

Both in my test VM and on Jenkins the UEFI scenario fails. We reach the part where the kernel command-line is shown, but we never manage to find TailsBootMenuKernelCmdlineUEFI.png even though the matching area is in plain sight. I’ve tried updating the image without success. I’ve tried lowering the sensitivity (0.5, which is very generous):

--- a/features/step_definitions/common_steps.rb
+++ b/features/step_definitions/common_steps.rb
@@ -239,7 +239,9 @@ Given /^Tails is at the boot menu's cmdline( after rebooting)?$/ do |reboot|
         Process.kill("CONT", tab_spammer.pid)
         dealt_with_uefi_setup = true
       end
-      @screen.wait(boot_menu_cmdline_image, 15)
+      p = Sikuli::Pattern.new(boot_menu_cmdline_image)
+      p.similar(0.5)
+      @screen.wait(p, 15)
     rescue FindFailed => e
       debug_log('We missed the boot menu before we could deal with it, ' +
                 'resetting...')

also without success. I’ve even pause()d and tried to match it, but it just doesn’t work. Perhaps we’re hitting some corner-case of Sikuli’s image detection?

Also, if I remove the tab spammer, then the Tiano Core splash screen is shown for a shorter duration, indicating that the spammer makes makes the splash show for significantly longer: I’ve seen > 10x, so the boot splash never managed to appear, which is worrying. Also, pressing TAB doesn’t seem to open the UEFI configuration, so we might be able to drop that workaround.

Feature Branch: test/16820-uefi+force-all-tests

Parent Task: #16281 (closed)

Related issues

• Related to #13459

Original created by @anonym on 16820 (Redmine)