persistence.feature fails due to NetworkManager test

Checking the snapshot removal (#16316 (closed)) helped with persistence.feature, that seems way better. This fails though:

    And Tor is ready                                                                                              # features/step_definitions/common_steps.rb:352
    And I add a current wired DHCP NetworkManager connection called "persistent-con-current"                      # features/step_definitions/common_steps.rb:576
      Unsupported version 'current ' (RuntimeError)
      ./features/step_definitions/common_steps.rb:578:in `/^I add a ([a-z0-9.]+ |)wired DHCP NetworkManager connection called "([^"]+)"$/'
      features/persistence.feature:37:in `And I add a current wired DHCP NetworkManager connection called "persistent-con-current"'

Failing Scenarios:
cucumber features/persistence.feature:33 # Scenario: Creating and using a persistent NetworkManager connection

6 scenarios (1 failed, 5 passed)
46 steps (1 failed, 8 skipped, 37 passed)
75m27.923s

which isn’t surprising given the current implementation in features/step_definitions/common_steps.rb:

Given /^I add a ([a-z0-9.]+ |)wired DHCP NetworkManager connection called "([^"]+)"$/ do |version, con_name|
  if not version.empty?
    raise "Unsupported version '#{version}'"
  else
    $vm.execute_successfully(
      "nmcli connection add con-name #{con_name} " + \
      "type ethernet autoconnect yes ifname eth0"
    )
  end
  try_for(10) {
    nm_con_list = $vm.execute("nmcli --terse --fields NAME connection show").stdout
    nm_con_list.split("\n").include? "#{con_name}"
  }
end

as we have a non-empty version (i.e. current).

Parent Task: #16281 (closed)

Related issues

• Related to #16316 (closed)

Original created by @CyrilBrulebois on 16317 (Redmine)