Tails Installer 4.x crashes when a pristine USB drive is plugged

The fix for #10539 (closed), or the last merge from master, introduced a regression in 4.4.4+dfsg-0tails2: when a pristine USB drive is plugged, the Installer crashes:

Traceback (most recent call last):
File "/usr/lib/tails_installer/tails-installer", line 105, in <module> main()
File "/usr/lib/tails_installer/tails-installer", line 99, in main win = TailsInstallerWindow(opts=opts, args=sys.argv)
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 332, in __init__ self.populate_devices()
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 523, in populate_devices
self.live.detect_supported_drives(callback=add_devices)
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 701, in detect_supported_drives
callback()
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 503, in add_devices
if not self.opts.partition and not self.live.device_can_be_upgraded(info):
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 929, in device_can_be_upgraded
if self.is_partition_GPT(device) and device['fstype'] == 'vfat' \
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 915, in is_partition_GPT
partition_table = self._udisksclient.get_partition_table(obj.props.partition)
TypeError: Argument 1 does not allow None as a value

Sounds like we assume too much wrt. the content of the drive we’re looking at.

(Identified by our automated test suite.)

Feature Branch: 451f:liveusb-creator/bugfix/10660+dontcrashpristineusb

Parent Task: #8549 (closed)

Related issues

• Blocks #7563 (closed)

Original created by @intrigeri on 10660 (Redmine)