Skip to content

whois test is fragile

Seen in a few recent jobs from jenkins.

calling as amnesia: whois 'torproject.org'
call returned: [0, "WHOIS LIMIT EXCEEDED - SEE WWW.PIR.ORG/WHOIS FOR DETAILS\n", ""]
    When I query the whois directory service for "torproject.org"                  # features/step_definitions/torified_misc.rb:1
    Then the whois command is successful                                           # features/step_definitions/torified_misc.rb:25
    Then the whois standard output contains "The Tor Project"                      # features/step_definitions/torified_misc.rb:34
      The whois standard output does not contain The Tor Project:
      WHOIS LIMIT EXCEEDED - SEE WWW.PIR.ORG/WHOIS FOR DETAILS

      .
      <nil> is not true. (Test::Unit::AssertionFailedError)
      ./features/step_definitions/torified_misc.rb:35:in `/^the (wget|whois) standard output contains "([^"]+)"$/'
      features/torified_misc.feature:24:in `Then the whois standard output contains "The Tor Project"'

This was addressed previously but when the retry_tor code was refactored this regression sneaked in. The problem stems from the fact that whois still “succeeds” because it exits 0 and it exits 0 because whois itself did what it was supposed to; it returned what the server sent.

Feature Branch: kytv/test/10523-whois-test-is-fragile

Parent Task: #10288

Original created by @kytv on 10523 (Redmine)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information