MAC spoofing panic mode is broken

It’s really stupid. Look at config/chroot_local-includes/usr/local/sbin/tails-unblock-network. It will wait for config/chroot_local-includes/usr/local/sbin/tails-spoof-mac (via the udevadm settle) to do its thing. If the thing is panic mode, i.e. to stop NetworkManager, well tails-unblock-network will start NetworkManager any way.

In other words, if MAC spoofing is enabled, and for whatever reason some NIC cannot be spoofed and its module cannot be unloaded, then the MAC spoofing panic mode is broken => the error notification will be shown but networking will be enabled from the failing device.

(For the record, I discovered this while working on #6302 (closed). Automated testing (or testing at all) FTW :))

Feature Branch: bugfix/10160-mac-spoofing-panic

Related issues

Blocks #6302 (closed)

Original created by @anonym on 10160 (Redmine)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information