From 2daac1d12c4784443a872492b7f29d02c429d19f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Parm=C3=A9nides=20GV?= <parmegv@sdf.org>
Date: Sun, 3 Apr 2016 17:19:04 +0200
Subject: [PATCH] Bitmask does not show the log if an error happens.
ics-openvpn already shows it if necessary. Our heuristic (just looking
for an "error" keyword in the past N messages of the log) is very weak,
and it returns an annoying false positive: turning off the VPN triggers
the show log error.
---
app/src/main/java/se/leap/bitmaskclient/VpnFragment.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java b/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
index 2e3d7524..9210c6ec 100644
--- a/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
+++ b/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
@@ -244,10 +244,7 @@ public class VpnFragment extends Fragment implements Observer {
Context context = dashboard.getApplicationContext();
String error = eip_status.lastError(5, context);
- if (!error.isEmpty()) {
- dashboard.showLog();
- VoidVpnService.stop();
- }
+ if (!error.isEmpty()) VoidVpnService.stop();
updateIcon();
updateButton();
}
--
GitLab